Add signed trust-root bundle verification#6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds signed trust-root bundle verification for nlboot trusted-key documents.
This PR adds:
load_verified_trust_bundle(...)for consumers that require bundle authenticitySoftware review
Correctness: moves trust-root documents from unsigned lifecycle metadata to bundle-level authenticity checks.
Risk: moderate. This introduces stricter verification semantics but remains side-effect-free.
Weakness: tests monkeypatch the low-level RSA verifier for positive-path bundle verification rather than embedding a private signing key fixture. A later tranche should add generated deterministic signing fixtures or test vectors.