Conversation
|
@copilot Please fix the remaining RC failure on this PR branch. Root cause: Rust |
Agent-Logs-Url: https://github.com/SociOS-Linux/nlboot/sessions/81ccb471-24d4-4d98-99a9-dfe20c34d90c Co-authored-by: mdheller <21163552+mdheller@users.noreply.github.com>
…cit key sorting
- Replace `ring` dependency with `rsa = { version = "0.9", features = ["sha2"] }`
Root cause: ring's parse_public_key expects PKCS#1 RSAPublicKey DER but trusted
key PEM is SubjectPublicKeyInfo format. rsa crate's from_public_key_pem() handles
SubjectPublicKeyInfo correctly.
- Add sort_value_keys() helper that recursively sorts JSON object keys (matching
Python's json.dumps(sort_keys=True)) by explicitly sorting entries before collecting,
preserving array order. Used in canonical_manifest_payload().
- Remove pem = \"3\" dependency (no longer needed directly).
- Add rust/nlboot-client/.gitignore to exclude target/ directory.
- Update Cargo.lock to reflect new dependencies.
All 13 Rust tests pass. make validate, rust-check, rust-test and all fixture
targets pass.
Agent-Logs-Url: https://github.com/SociOS-Linux/nlboot/sessions/81ccb471-24d4-4d98-99a9-dfe20c34d90c
Co-authored-by: mdheller <21163552+mdheller@users.noreply.github.com>
Fixed in fdd8c6d. Root cause was actually two issues:
All 13 Rust tests pass. |
This PR exists to trigger and prove
.github/workflows/release-candidate.ymlthrough the normal pull-request path.Scope:
docs/RELEASE_CANDIDATE_PROOF.mdonly;Acceptance: