Skip to content

workstation-v0 surface aggregate polish warnings in status#119

Merged
mdheller merged 2 commits intomainfrom
feat/workstation-polish-status
May 2, 2026
Merged

workstation-v0 surface aggregate polish warnings in status#119
mdheller merged 2 commits intomainfrom
feat/workstation-polish-status

Conversation

@mdheller
Copy link
Copy Markdown
Member

@mdheller mdheller commented Apr 30, 2026

Adds minimal status integration for aggregate workstation polish warnings.

Scope:

  • consume check-workstation-polish.sh from sourceos status
  • append warnings only
  • preserve existing status JSON shape
  • add workstation-status-polish smoke workflow

Validation:

  • bash -n profiles/linux-dev/workstation-v0/bin/sourceos
  • status JSON must keep keys: profile, ok, gnome, required_missing, optional_missing, warnings
  • invalid aggregate keyboard policy must add a warning without changing JSON shape

Critic notes:

  • no doctor.sh change
  • no unrelated files touched

Copy link
Copy Markdown
Member Author

mdheller commented May 2, 2026

Agent critic: scope is correct and the PR is one-file scoped, but this PR is missing required validation evidence under the current dispatch/merge operating rules.

Before merge, please update the PR body or add a comment with:

  • exact validation commands run;
  • pass/fail output summary;
  • confirmation that sourceos status --json still preserves the existing JSON shape;
  • confirmation that no unrelated files were touched.

Do not broaden scope.

Copy link
Copy Markdown
Member Author

mdheller commented May 2, 2026

Agent critic follow-up: this PR is still blocked from merge until validation evidence is visible.

The repo already has an appropriate validation gate in .github/workflows/workstation-scripts.yml:

  • Smoke: sourceos status JSON parses
  • expected JSON keys: profile, ok, gnome, required_missing, optional_missing, warnings

That workflow step is sufficient to prove the PR preserves the existing sourceos status --json shape, but I cannot currently see a workflow run attached to this PR head through the connector.

Required before merge:

  1. get the workstation-scripts workflow to run on this PR head, or
  2. update the PR body with equivalent local validation evidence showing:
    • command: SOURCEOS_PROFILE_DIR=profiles/linux-dev/workstation-v0 bash profiles/linux-dev/workstation-v0/bin/sourceos status --json
    • exit code was 0 or 2
    • JSON parsed successfully
    • keys remained profile, ok, gnome, required_missing, optional_missing, warnings

Do not broaden scope.

@mdheller mdheller merged commit 9849894 into main May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant