feat(cmd): execute vocab validate in standards repo working dir#13
Closed
mdheller wants to merge 1 commit intofeat/vocab-surfacefrom
Closed
feat(cmd): execute vocab validate in standards repo working dir#13mdheller wants to merge 1 commit intofeat/vocab-surfacefrom
mdheller wants to merge 1 commit intofeat/vocab-surfacefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR advances the
vocabruntime surface by adding real local execution forprophet vocab validate.Included
internal/exec/runner.gosupports execution in a specified working directoryinternal/vocab/vocab.goresolves a standards repo path and runspolicy/tools/validate_all.pythereinternal/cmd/vocab.gonow emits the returned result payload even on validator failureBehavior
prophet vocab validatenow:PROPHET_VOCAB_REPO, or defaults to../socioprophet-standards-knowledge.when none are providedpython3 policy/tools/validate_all.py --data ...in the standards repo working directoryWhy
The standards chain in
socioprophet-standards-knowledgeis now staged through PRs #28-#31. The runtime CLI needs to be able to invoke that validator contract for real, not merely advertise it.Note on review chain
This branch was originally intended to stack on top of #12. The live
feat/vocab-runtime-plumbingbranch is not currently visible in the repository branch list, so this PR is opened againstfeat/vocab-surfaceas the nearest live review base. Functionally, it carries the runtime-plumbing step forward and can supersede #12 if needed.Scope
Still intentionally narrow: