fix: prefer system npm/npx over project-local versions from node_modules#1172
Merged
fix: prefer system npm/npx over project-local versions from node_modules#1172
Conversation
When the CLI runs inside an npm script (or any context where node_modules/.bin is on PATH), getNpxBinPath() could pick up a project-local npx instead of the system one. The standalone npx package (npx@10.2.2) bundles npm@5.1.0 which is incompatible with Node 22+, causing "cb.apply is not a function" errors during Coana reachability analysis. Fix: check for npm/npx next to process.execPath (the running node binary) before falling back to PATH-based lookup. This follows the same pattern already used by findRealNpm() in @socketsecurity/registry and getAgentExecPath() in package-environment.mts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jdalton
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node_modules/.binis on PATH),getNpxBinPath()could pick up a project-local npx instead of the system onenpxpackage (npx@10.2.2) bundlesnpm@5.1.0which is incompatible with Node 22+, causingcb.apply is not a functionerrors during Coana reachability analysisprocess.execPathbefore falling back to PATH-based lookup, following the same pattern already used byfindRealNpm()in@socketsecurity/registryandgetAgentExecPath()inpackage-environment.mtsTest plan
npx@10.2.2in a project, run scan with reachability from an npm script — should no longer crash🤖 Generated with Claude Code
Note
Medium Risk
Medium risk because it changes how the CLI locates and executes
npm/npx, which can affect behavior across environments (especially Windows and custom Node installs), though the change is narrowly scoped to path resolution.Overview
Ensures the CLI prefers system
npm/npxover project-local versions that may appear onPATH(e.g. fromnode_modules/.bin) by first probing for binaries next toprocess.execPath.Adds
findBinNextToNode()(with symlink resolution viaresolveBinPathSync) and uses it ingetNpmBinPathDetails()/getNpxBinPathDetails()before falling back to the existingPATH-based lookup, reducing failures from incompatible bundled npm/npx versions on newer Node runtimes.Reviewed by Cursor Bugbot for commit 7a6441d. Configure here.