fix: clean up check-new-deps hook#1211
Merged
John-David Dalton (jdalton) merged 1 commit intomainfrom Apr 17, 2026
Merged
Conversation
The malware API only checks for malware, not quality scores. Remove dead warned/score logic and the wrong SDK batch heuristic comment.
9b0fa8b to
55fab25
Compare
Bradley Farias (bmeck)
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
criticalvariable tomalwarefor clarityTest plan
cd .claude/hooks/check-new-deps && npm testNote
Low Risk
Behavior is narrowed to malware-only blocking with mostly removal/cleanup; limited risk aside from potentially no longer surfacing non-blocking low-score warnings.
Overview
Simplifies the
check-new-depspre-tool hook to only block on malware results fromSocketSdk.checkMalware(), removing the previous low-quality-score warning path and related return structure.Updates messaging/comments/docs to match the new behavior (malware-only blocking), and renames internal variables for clarity when evaluating alerts.
Reviewed by Cursor Bugbot for commit 55fab25. Configure here.