chore(patches): remove patches for versions no longer resolved#1217
Merged
Conversation
Drops patches/@npmcli__run-script@10.0.3.patch and patches/node-gyp@12.1.0.patch. pnpm-workspace.yaml's patchedDependencies only references the newer 10.0.4 and 12.2.0 versions, and the older versions aren't resolved anywhere in the lockfile. Keeping the files around just makes the patches/ directory harder to read.
Bill Li (billxinli)
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
patches/@npmcli__run-script@10.0.3.patch(current patched version is 10.0.4)patches/node-gyp@12.1.0.patch(current patched version is 12.2.0)Why
pnpm-workspace.yamlonly points at the newer versions, and grepping the lockfile confirms the older versions aren't resolved anywhere. The files were just orphans adding noise topatches/.Test plan
pnpm installstill resolves (no lockfile change needed)pnpm run build:clisucceedsNote
Low Risk
Only deletes patch artifacts for versions not used by the lock/workspace, so behavior should be unchanged aside from a cleaner repo.
Overview
Removes two orphaned
pnpmpatch files for dependency versions that are no longer resolved:patches/@npmcli__run-script@10.0.3.patchandpatches/node-gyp@12.1.0.patch.No runtime behavior changes are introduced for currently-installed dependencies; this is cleanup to reduce noise in
patches/.Reviewed by Cursor Bugbot for commit b93cd58. Configure here.