Skip to content

chore(tools): add checksum for socket-basics archive#1222

Merged
John-David Dalton (jdalton) merged 1 commit intomainfrom
chore/socket-basics-checksum
Apr 17, 2026
Merged

chore(tools): add checksum for socket-basics archive#1222
John-David Dalton (jdalton) merged 1 commit intomainfrom
chore/socket-basics-checksum

Conversation

@jdalton
Copy link
Copy Markdown
Contributor

@jdalton John-David Dalton (jdalton) commented Apr 17, 2026

Summary

Adds a SHA-256 checksum for the socket-basics source archive in bundle-tools.json and wires it through the downloader so it gets verified like every other bundled tool.

Before

socket-basics was the one entry in bundle-tools.json without a checksums block, so its download went unverified while the other tools (opengrep, trivy, trufflehog, sfw, python, etc.) all had per-asset SHA-256 entries enforced.

After

  • bundle-tools.json now has:
    "checksums": {
      "socket-basics-v2.0.2.tar.gz": "ba17...eb13"
    }
  • downloads.mts passes sha256: archiveSha256 into the same httpDownload(...) helper the rest of the tools use, and throws if the checksum entry is missing (matching the existing pattern at lines 327–345 / 472–508).

Notes

  • The checksum key uses the tag-qualified filename (socket-basics-v<ver>.tar.gz) to stay consistent with the asset-keyed checksums elsewhere in the file and the local-path convention used in downloads.mts.
  • Future version bumps can be handled by the /sync-checksums skill that already exists for the other tools.

Test plan

  • pnpm run type green
  • node scripts/validate-checksums.mts green
  • pnpm run build:cli succeeds
  • CI green (exercises the SEA build path which actually fetches the archive)

Note

Low Risk
Small, scoped change that only tightens download verification for a bundled tool; primary risk is build failures if the checksum key/name is incorrect.

Overview
Adds a checksums entry for the socket-basics GitHub source tarball in bundle-tools.json.

Updates SEA build tooling to require that checksum and pass it to httpDownload when fetching the socket-basics archive; the build now fails fast with a clear error if the checksum is missing.

Reviewed by Cursor Bugbot for commit f4844e9. Configure here.

Adds a SHA-256 checksum for the socket-basics source archive in
bundle-tools.json and wires it through to the downloader so the
download now gets verified like every other bundled tool.

Previously:
  - socket-basics was the only bundled tool without a checksum in
    bundle-tools.json, so the download was trusted as-is.

Now:
  - `bundle-tools.json` has `checksums["socket-basics-v2.0.2.tar.gz"]`.
  - `downloads.mts` passes `sha256: archiveSha256` to the same
    `httpDownload(...)` helper the other tools already use, and throws
    if the checksum entry is missing.

Note: the archive key uses the tag-qualified filename
(`socket-basics-v<ver>.tar.gz`) to match the existing local-path
convention (`socket-basics-${version}.tar.gz`) and stay consistent
with the asset-keyed checksums elsewhere in the file.
@jdalton John-David Dalton (jdalton) merged commit bb6b4c8 into main Apr 17, 2026
14 checks passed
@jdalton John-David Dalton (jdalton) deleted the chore/socket-basics-checksum branch April 17, 2026 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants