docs(claude): always existsSync; forbid async fileExists#1228
Merged
John-David Dalton (jdalton) merged 1 commit intomainfrom Apr 17, 2026
Merged
docs(claude): always existsSync; forbid async fileExists#1228John-David Dalton (jdalton) merged 1 commit intomainfrom
John-David Dalton (jdalton) merged 1 commit intomainfrom
Conversation
Strengthen the File Organization rules:
- Tighten the fs import example to the canonical form
`import { existsSync, promises as fs } from 'node:fs'` (was
`someSyncThing` placeholder).
- Explicitly forbid async `fileExists` wrappers and
`fs.stat`-for-existence checks in addition to `fs.access`.
No code changes.
James Tu (jmsjtu)
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import { existsSync, promises as fs } from 'node:fs'(wassomeSyncThingplaceholder).fileExistswrappers andfs.stat-for-existence checks in addition tofs.access.Docs-only; no code changes. Keeps socket-cli's CLAUDE.md in sync with the shared rule being rolled out across the socket-* repos.
Test plan
pnpm run fix+pnpm run checkpassed via pre-commit hooksNote
Low Risk
Low risk because this PR only updates guidance in
CLAUDE.mdwith no runtime code changes. Risk is limited to potential developer confusion if teams were relying on the previously looser wording.Overview
Clarifies the
CLAUDE.mdNode.jsfsguidance by standardizing the import example toimport { existsSync, promises as fs } from 'node:fs'.Tightens the file-existence rule to explicitly forbid
fs.access,fs.stat-for-existence checks, and any asyncfileExistswrapper in favor of usingexistsSync.Reviewed by Cursor Bugbot for commit e41555d. Configure here.