chore(provenance): drop publish-without-sfw escape hatch#1253
Merged
John-David Dalton (jdalton) merged 1 commit intov1.xfrom Apr 22, 2026
Merged
Conversation
The escape hatch renamed sfw shims to *.disabled around publish steps, from before the firewall had a 'bypass' registry kind. With sfw-enterprise now live (SOCKET_API_TOKEN), bypass covers github.com, codeload, and the release-asset CDNs — publish flows don't need to strip shims anymore. - Drop publish-without-sfw input declaration. - Drop the 'Strip sfw shims for publishing' step. - Drop the 'Restore sfw shims after publishing' step. Mirrors socket-registry d638c11f.
Martin Torp (mtorp)
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
publish-without-sfwescape hatch from the provenance workflow onv1.x. With the sfw checksum/version pin from #1252 in place andsfw-enterpriselive (viaSOCKET_API_TOKEN), the firewall'sbypassregistry kind already covers github.com, codeload, and the release-asset CDNs — so publish flows don't need to strip shims anymore.What changed
.github/workflows/provenance.yml:publish-without-sfwworkflow_dispatchinput.*.disabledbefore publish).Net: -26 lines, no behavior change for normal publishes — the escape hatch was off by default.
Why now
The escape hatch existed because earlier sfw versions blocked legitimate publish traffic. That's no longer true — bypass covers what publish needs. Mirrors socket-registry's
d638c11f.Test plan
workflow_dispatchof "Publish to npm registry" no longer shows thepublish-without-sfwcheckbox.Note
Low Risk
Low risk workflow simplification: removes an optional publishing bypass path without changing the default publish behavior. Risk is limited to cases where publishes previously relied on disabling the
sfwshims to succeed.Overview
Removes the
publish-without-sfwmanual input from theprovenance.ymlpublish workflow and deletes the conditional steps that temporarily disabled and then restoredsfwshim wrappers around publish.Publishing now always runs with the
sfwshims in place, eliminating the escape hatch while keeping the existing build and multi-variantnpm publishsteps unchanged.Reviewed by Cursor Bugbot for commit 9ed63f3. Configure here.