fix(cli): align test/ error messages with 4-ingredient strategy

[John-David Dalton (jdalton)]

Summary

PR 6 of the error-message series. Covers test utilities: packages/cli/src/test/ (the Socket-JSON contract validator + auth-flow mocks, which are shared across the test suite) and packages/cli/test/ (the bash smoke harness + its JS counterpart).

~16 messages across 4 files. Full test suite (343 files / 5225 tests) still passes.

What's fixed

src/test/json-output-validation.mts (6 throws)

Socket CLI guarantees a JSON output contract: {ok: true, data: ...} on success or {ok: false, message: ...} on failure. This file's validator is the guardrail. Before, it said things like "JSON output missing required 'ok' boolean field" which didn't tell a failing test author what the full contract looked like or how to satisfy it.

Before: JSON output 'ok' should be true when exit code is 0: {full payload...}
After: Socket JSON contract violation: exit code is 0 but "ok" is false (expected true); got: {preview}... — set ok:true when the command succeeds, or return a non-zero exit code

Long payloads are now truncated to 200 chars in the message so stacktraces stay readable.

src/test/mocks/socket-auth.mts (2 throws)

throw new Error('Authentication failed') and throw new Error('OAuth timeout') — before, a test failure here looked like a real auth outage. Now both errors explicitly identify themselves as test fixtures and point at the config flag that controls them.

test/json-output-validation.mts (2 non-throwing returns)

This is a lighter shim that returns {ok: false, message: ...} instead of throwing. Updated to match the throw-path messages so a failing integration test shows the parse error and a stdout preview.

test/smoke.sh (6 label strings)

The bash smoke harness duplicates the JS validator's logic in shell. Updated its labels to mirror the new wording so the two harnesses produce consistent errors.

Tests

Nothing else needed updating — grep confirmed the "Authentication failed" and "Unknown error" hits elsewhere are unrelated (tests constructing their own new AuthError('Authentication failed') as test data, or matching on a distinct production error in src/utils/socket/api.mts).

Full suite: 5225/5225 tests pass.

Test plan

• CI green
• Sanity: break the JSON output of any --json command and verify the new validator message points at the contract violation clearly

---

Note

Low Risk
Low risk: changes are confined to test utilities and smoke harness messaging, with no production logic impact aside from clearer failures when tests detect malformed JSON or misconfigured mocks.

Overview
Tightens and standardizes test-time validation of the Socket CLI --json output contract by upgrading error messages to explicitly call out contract violations, include actionable guidance, and show a truncated stdout preview for readability.

Updates the auth-flow test mocks to throw fixture-specific failures (instead of generic auth errors), and aligns both the JS integration validator and test/smoke.sh labels with the same clearer parse/contract diagnostics.

^{Reviewed by Cursor Bugbot for commit a8efd4f. Configure here.}

[John-David Dalton (jdalton)]

bugbot run

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit a8efd4f. Configure here.}