Skip to content

chore(deps): bump postcss to >=8.5.10 (GHSA-qx2v-qp2m-jg93)#1276

Merged
John-David Dalton (jdalton) merged 1 commit intomainfrom
chore/postcss-bump
Apr 25, 2026
Merged

chore(deps): bump postcss to >=8.5.10 (GHSA-qx2v-qp2m-jg93)#1276
John-David Dalton (jdalton) merged 1 commit intomainfrom
chore/postcss-bump

Conversation

@jdalton
Copy link
Copy Markdown
Contributor

@jdalton John-David Dalton (jdalton) commented Apr 25, 2026

Summary

Fixes https://github.com/SocketDev/socket-cli/security/dependabot/134.

postcss < 8.5.10 does not escape </style> sequences when stringifying CSS ASTs. When user-submitted CSS is re-stringified for embedding in HTML <style> tags, </style> in CSS values breaks out of the style context and allows XSS via a following <script>. See GHSA-qx2v-qp2m-jg93 / CVE-2026-41305. CVSS v3.1 6.1 (medium).

What's changed

  • pnpm-workspace.yaml: add postcss: '>=8.5.10' to the overrides block.
  • pnpm-lock.yaml: regenerated — postcss bumped 8.5.9 → 8.5.10 (both importers: the direct resolution and the vite transitive).

Why an override vs. dep bump

postcss is a transitive dev-scope dep (via vite@7.3.2). The overrides block is the right tool here — matches the existing shape (defu: '>=6.1.7', glob: '>=13.0.6', qs: '>=6.15.1' are the same pattern for the same reason). Overriding sets a floor without pinning exact, so future patch bumps land organically.

Test plan

  • Dependabot alert auto-resolves after merge (floor now >= 8.5.10).
  • CI green.
  • pnpm install in a clean clone succeeds.

Note

Low Risk
Low risk: dependency override plus lockfile regen to pick up a patch release; main risk is minor build/CSS tooling behavior differences from the PostCSS patch update.

Overview
Security-driven dependency update: adds a pnpm overrides floor of postcss: '>=8.5.10' in pnpm-workspace.yaml.

Regenerates pnpm-lock.yaml so postcss resolves to 8.5.10 (including the vite transitive), addressing the advisory affecting older PostCSS versions.

Reviewed by Cursor Bugbot for commit de68c95. Configure here.

Transitive dev-scope dependency pulled in via vite@7.3.2. The pre-8.5.10
line does not escape `</style>` in stringify output; a malicious
PostCSS plugin could inject XSS when output is embedded in HTML
<style> tags. Upstream advisory:
GHSA-qx2v-qp2m-jg93

- CVE-2026-41305 / CVSS v3.1 6.1 (medium).
- First patched: 8.5.10.
- socket-cli does not use PostCSS at runtime, but Dependabot flags
  the lockfile presence so we pin the floor anyway — same discipline
  as the existing defu / glob / qs overrides.

Fix: add `postcss: '>=8.5.10'` to the pnpm-workspace overrides
block. Regenerated pnpm-lock.yaml reflects postcss@8.5.10.

Fixes https://github.com/SocketDev/socket-cli/security/dependabot/134
@jdalton John-David Dalton (jdalton) merged commit 2d8dd6c into main Apr 25, 2026
14 checks passed
@jdalton John-David Dalton (jdalton) deleted the chore/postcss-bump branch April 25, 2026 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants