chore(ci): remove the unused maven-extension-jar workflow#1386
Open
Jeppe Fredsgaard Blaabjerg (jfblaa) wants to merge 1 commit into
Open
chore(ci): remove the unused maven-extension-jar workflow#1386Jeppe Fredsgaard Blaabjerg (jfblaa) wants to merge 1 commit into
Jeppe Fredsgaard Blaabjerg (jfblaa) wants to merge 1 commit into
Conversation
The Maven extension jar is built and bundled at release time by provenance.yml (which fails the build if the jar is missing), and the build-tool version-compat matrix is run locally on demand via run-compat.sh. The standalone PR-time jar-build workflow is redundant, so drop it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
maven-extension-jarworkflow added in #1385. It's redundant:provenance.yml, which now fails closed if the jar is missing (no jarless package can ship).src/commands/manifest/scripts/test/run-compat.sh.So the standalone PR-time jar-build check isn't needed. The trade-off: a maven-extension build break is caught at release time (the release fails) rather than on the PR — acceptable given the fail-closed release build and local testing.
Note
Low Risk
CI-only removal with no runtime or release-script changes; jar build and fail-closed bundling remain in the release workflow.
Overview
Deletes the
.github/workflows/maven-extension-jar.ymlworkflow that built the Maven manifest extension jar and ran a Maven 3.9.9 smoke test on PRs andworkflow_dispatch.PR-time coverage is dropped in favor of existing paths:
provenance.ymlstill runspnpm run build:maven-extensionbefore publish and fails closed if the jar is missing, and the version-compat matrix is exercised locally viarun-compat.sh. A broken extension build would surface at release rather than on every PR touching the extension.Reviewed by Cursor Bugbot for commit ce17821. Configure here.