Skip to content

Polish the config/token override stuff#407

Merged
jdalton merged 3 commits intomainfrom
config_override_polish
Apr 4, 2025
Merged

Polish the config/token override stuff#407
jdalton merged 3 commits intomainfrom
config_override_polish

Conversation

@pvdz
Copy link
Contributor

@pvdz pvdz commented Apr 4, 2025

  • Fixes using the SOCKET_SECURITY_API_TOKEN env var. Also supports API_KEY and the prefix SOCKET_CLI for consistency. In a next major we'll probably deprecate the KEY variants.
  • Make the CLI emit a proper error message when the config override cannot be parsed, rather than a generic JSON error with stack trace.
  • Add some tests around this
  • Add notice to config commands when the config is in read-only mode
  • Warn when logging in/out while config is in read-only mode

@pvdz pvdz requested a review from jdalton April 4, 2025 13:52
@pvdz pvdz marked this pull request as ready for review April 4, 2025 13:52
@jdalton jdalton merged commit e95af7f into main Apr 4, 2025
4 checks passed
@jdalton jdalton deleted the config_override_polish branch April 4, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants