Add back some install passes and fix isTopLevel#559
Merged
John-David Dalton (jdalton) merged 1 commit intomainfrom May 18, 2025
Merged
Add back some install passes and fix isTopLevel#559John-David Dalton (jdalton) merged 1 commit intomainfrom
John-David Dalton (jdalton) merged 1 commit intomainfrom
Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+73
to
+75
| const actualTree = await newArb.reify() | ||
| arb.actualTree = actualTree | ||
| return actualTree |
Contributor
There was a problem hiding this comment.
According to the project's coding style that requires explicit semicolons, each statement in this refactored code should end with a semicolon. Consider updating the code to:
const actualTree = await newArb.reify();
arb.actualTree = actualTree;
return actualTree;This maintains consistency with the project's semicolon usage conventions.
Suggested change
| const actualTree = await newArb.reify() | |
| arb.actualTree = actualTree | |
| return actualTree | |
| const actualTree = await newArb.reify() | |
| arb.actualTree = actualTree | |
| return actualTree |
Spotted by Diamond (based on custom rules)
Is this helpful? React 👍 or 👎 to let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.