Reduce reliance on github action specific environment vars#653
Merged
Conversation
Comment on lines
+19
to
+21
| if (!GITHUB_REPOSITORY) { | ||
| debugFn('miss: GITHUB_REPOSITORY env var') | ||
| } |
Contributor
There was a problem hiding this comment.
The debug statement logs when GITHUB_REPOSITORY is missing but the function continues execution with a potentially undefined value. Since the next line uses ownerSlashRepo without checking if it's defined, consider adding a return null after the debug call to fail early and prevent attempting to parse an undefined string.
Suggested change
| if (!GITHUB_REPOSITORY) { | |
| debugFn('miss: GITHUB_REPOSITORY env var') | |
| } | |
| if (!GITHUB_REPOSITORY) { | |
| debugFn('miss: GITHUB_REPOSITORY env var') | |
| return null | |
| } |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.