Skip to content

upload manifest filess relative to target for coana-fix and perform-r… #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 26, 2025
Merged

upload manifest filess relative to target for coana-fix and perform-r… #943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bacb69
upload manifest filess relative to target for coana-fix and perform-r…
jfblaa Nov 26, 2025
3bb089c
slightly more verbose, but hopefully more intuitive relative path arg…
jfblaa Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "socket",
"version": "1.1.35",
"version": "1.1.36",
"description": "CLI for Socket.dev",
"homepage": "https://github.com/SocketDev/socket-cli",
"license": "MIT AND OFL-1.1",
Expand Down
2 changes: 1 addition & 1 deletion src/commands/fix/coana-fix.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ export async function coanaFix(
p => path.basename(p).toLowerCase() !== DOT_SOCKET_DOT_FACTS_JSON,
)
const uploadCResult = await handleApiCall(
sockSdk.uploadManifestFiles(orgSlug, filepathsToUpload),
sockSdk.uploadManifestFiles(orgSlug, filepathsToUpload, cwd),
{
description: 'upload manifests',
spinner,
Expand Down
7 changes: 6 additions & 1 deletion src/commands/scan/perform-reachability-analysis.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,13 @@ export async function performReachabilityAnalysis(

spinner?.start('Uploading manifests for reachability analysis...')

// Ensure uploaded manifest files are relative to analysis target as coana resolves SBOM manifest files relative to this path
const uploadCResult = await handleApiCall(
sockSdk.uploadManifestFiles(orgSlug, filepathsToUpload),
sockSdk.uploadManifestFiles(
orgSlug,
filepathsToUpload,
path.resolve(cwd, analysisTarget),
),
{
description: 'upload manifests',
spinner,
Expand Down