Skip to content

Conversation

@jfblaa
Copy link
Contributor

@jfblaa jfblaa commented Dec 8, 2025

implicitly use --all if no --id but warn that this is deprecated in local mode


Note

Adds --all to socket fix (cannot be combined with --id), warns in local mode when neither is provided, and threads the flag through CLI, logic, types, and tests.

  • socket fix CLI
    • Add --all flag to process all discovered vulnerabilities in local mode; update help text.
    • Enforce mutual exclusivity between --all and --id with input validation.
    • In local mode, continue discovering when no --id, but log deprecation warning if --all not provided.
  • Implementation
    • Thread all through cmd-fix.mtshandle-fix.mtscoana-fix.mts and types.mts.
    • Update discovery logic to use all || !ghsas.length.
  • Tests
    • Add integration tests for --all acceptance, incompatibility with --id, and use with --ecosystems.
  • Release
    • Bump version to 1.1.43 and update CHANGELOG.md.

Written by Cursor Bugbot for commit 5494efb. Configure here.

implicitly use `--all` if no `--id` but warn that this is deprecated in local mode
@jfblaa jfblaa requested review from barslev, jdalton and mtorp December 8, 2025 08:53
@jdalton jdalton merged commit da83fa1 into v1.x Dec 8, 2025
8 checks passed
@jdalton jdalton deleted the jfblaa/rea-327-add-explicit-all-for-socket-fix-local-mode branch December 8, 2025 12:04
jdalton added a commit that referenced this pull request Dec 9, 2025
Ported from v1.x commit da83fa1 (#967)

- Add --all flag to process all discovered vulnerabilities in local mode
- Make --all incompatible with --id (mutually exclusive)
- Add deprecation warning when neither --all nor --id provided in local mode
- Update shouldDiscoverGhsaIds logic to check all || !ghsas.length
- Pass all flag through cmd-fix -> handle-fix -> coana-fix
- Update test fixtures to include all parameter

Based on PR #967
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants