feat: add 1:1 upstream test ports for all 131 npm package overrides#259
Merged
John-David Dalton (jdalton) merged 1 commit intomainfrom Apr 13, 2026
Merged
feat: add 1:1 upstream test ports for all 131 npm package overrides#259John-David Dalton (jdalton) merged 1 commit intomainfrom
John-David Dalton (jdalton) merged 1 commit intomainfrom
Conversation
ac0ff14 to
f3ef741
Compare
- 81 new test files ported from upstream tagged releases with SHA refs - Add `pnpm run test:npm` script via run-vitest-npm.mjs launcher - Replace test-npm-packages.mjs CI pipeline with vitest on local tests - Load modules directly from packages/npm/ (no pnpm install needed) - Remove dead createNpmPackageBeforeAll, simplify npm-package-helper - Pass-through args for `pnpm run test:npm -- --reporter=verbose`
f3ef741 to
bfdb07a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every package in
packages/npm/now has a local test file ported 1:1 from the upstream repo's test suite. Each test references the exact tagged release SHA for traceability.This provides full test coverage without needing to download upstream packages, which fails intermittently due to pnpm v11
ERR_PNPM_MISSING_TIMEbug (pnpm/pnpm#11238).81 new test files covering:
Test plan