Skip to content

feat: add 1:1 upstream test ports for all 131 npm package overrides#259

Merged
John-David Dalton (jdalton) merged 1 commit intomainfrom
feat/local-test-ports
Apr 13, 2026
Merged

feat: add 1:1 upstream test ports for all 131 npm package overrides#259
John-David Dalton (jdalton) merged 1 commit intomainfrom
feat/local-test-ports

Conversation

@jdalton
Copy link
Copy Markdown
Collaborator

Summary

Every package in packages/npm/ now has a local test file ported 1:1 from the upstream repo's test suite. Each test references the exact tagged release SHA for traceability.

This provides full test coverage without needing to download upstream packages, which fails intermittently due to pnpm v11 ERR_PNPM_MISSING_TIME bug (pnpm/pnpm#11238).

81 new test files covering:

  • es-shims polyfills (array., string., object., typed-array-, etc.)
  • Type checkers (is-arguments, is-map, is-set, is-weakmap, etc.)
  • Utility packages (safe-buffer, path-parse, querystringify, etc.)
  • Iterator/Promise polyfills (es-iterator-helpers, promise.any, etc.)

Test plan

  • 0 lint errors (oxlint)
  • 0 TypeScript errors
  • 131 test files = 131 packages (100% coverage)
  • CI passes

@jdalton John-David Dalton (jdalton) force-pushed the feat/local-test-ports branch 8 times, most recently from ac0ff14 to f3ef741 Compare April 13, 2026 13:18
- 81 new test files ported from upstream tagged releases with SHA refs
- Add `pnpm run test:npm` script via run-vitest-npm.mjs launcher
- Replace test-npm-packages.mjs CI pipeline with vitest on local tests
- Load modules directly from packages/npm/ (no pnpm install needed)
- Remove dead createNpmPackageBeforeAll, simplify npm-package-helper
- Pass-through args for `pnpm run test:npm -- --reporter=verbose`
@jdalton John-David Dalton (jdalton) merged commit a3485e1 into main Apr 13, 2026
14 checks passed
@jdalton John-David Dalton (jdalton) deleted the feat/local-test-ports branch April 13, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant