Fix autobuilding of SDK#2
Merged
Pelle Wessman (voxpelli) merged 1 commit intomasterfrom Oct 19, 2022
Merged
Conversation
Pelle Wessman (voxpelli)
force-pushed
the
work-on-automated-update
branch
from
9fb3267 to
6a6b3cf
Compare
Socket Security Report👍 No new dependency issues detected in pull request Socket.dev scan summary
Bot CommandsTo ignore an alert, reply with a comment starting with Ignoring: Powered by socket.dev |
Socket Security Report👍 No new dependency issues detected in pull request Socket.dev scan summary
Bot CommandsTo ignore an alert, reply with a comment starting with Ignoring: Powered by socket.dev |
Contributor
Author
|
Socket (@SocketSecurity) ignore npm-run-all2@6.0.2 |
Pelle Wessman (voxpelli)
force-pushed
the
work-on-automated-update
branch
from
d356a17 to
f1038e6
Compare
John-David Dalton (jdalton)
added a commit
that referenced
this pull request
Apr 27, 2026
…Bugbot) Two issues from Cursor Bugbot's review: 1. token-guard sed redaction regex couldn't cross delimiter boundary (high). The pattern /\bsed\b[^|]*s[/|#][^/|#]*=[^/|#]*<?redact/i used [^/|#]* which stops at the / between sed pattern and replacement, so 'sed s/=.*/=<redacted>/' (the canonical fix the error message suggests) never matched. Replaced with [\s\S]*? to reach across the delimiter. 2. pre-push.mts .env detection only matched root-level .env / .env.local (high). commit-msg.mts and pre-commit.mts both use basename() with a broader pattern. pre-push is the mandatory enforcement layer for --no-verify bypasses; weaker detection there meant a nested packages/cli/.env.local would slip through. Aligned to basename- based matching with the same allowlist (.env.example/.env.test/ .env.precommit). Note on Bugbot finding #2 (rmSync in scripts/bootstrap-from-registry.mts): deliberate. The bootstrap script runs BEFORE pnpm install — that's its whole purpose — so @socketsecurity/lib's safeDelete isn't available yet. Discard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.