fix(test): resolve TypeScript errors in fixDetails type handling #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed TypeScript errors when accessing properties from index signature types in getRepoFixes test. The fixDetails response type uses Record<string, never> which requires proper type assertions to access nested properties. - Add type assertion for fixDetail object - Add explicit type guards and runtime checks - Define inline type for value object with proper structure - Use type-safe access for all nested properties This resolves TS4111 (index signature access) and TS18048 (undefined checks) errors while maintaining runtime safety.
Updated dependencies to latest versions: - pnpm: 10.27.0 → 10.28.0 (packageManager field) - @socketsecurity/lib: 5.2.1 → 5.4.1 - @dotenvx/dotenvx: ^1.51.2 → ^1.51.4 Updated lockfile with new dependency versions.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
bmeck
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed TypeScript compilation errors in test file that were blocking the test suite:
Changes
fixDetailobject accessed from index signaturevalueobject with proper structureTest Plan
pnpm test)pnpm tsc)pnpm check --all)Technical Details
The
fixDetailsresponse type usesRecord<string, never>which requires proper type assertions to access nested properties. This fix maintains type safety while allowing the test to access the mock response data structure.