Skip to content

fix: quality scan improvements#485

Merged
jdalton merged 4 commits intomainfrom
fix/quality-scan-improvements
Mar 3, 2026
Merged

fix: quality scan improvements#485
jdalton merged 4 commits intomainfrom
fix/quality-scan-improvements

Conversation

@jdalton
Copy link
Contributor

@jdalton jdalton commented Mar 2, 2026

Summary

  • Fix git push credentials in generate.yml workflow (remove persist-credentials: false)
  • Fix documentation default values in types.ts (retries: 3, retryDelay: 1000)
  • Fix incorrect API response field references in README.md and docs/api-reference.md
  • Fix quota-management.md method references and counts
  • Add createFullScan to quota data file alongside legacy createOrgFullScan
  • Fix formatBytes array bounds issue for TB+ files in validate-file-size.mjs
  • Add null safety for empty specifiers in validate-bundle-deps.mjs

Test plan

  • pnpm run check --all passes
  • pnpm test passes
  • Quality scan shows zero issues

🤖 Generated with Claude Code

jdalton added 3 commits March 2, 2026 15:53
- Fix git push credentials in generate.yml workflow by removing
  persist-credentials: false to allow pushing automated commits
- Add createFullScan entry to quota data file (alongside legacy
  createOrgFullScan) for accurate quota calculations
- Fix docs/api-reference.md: replace non-existent includeTopLevelAncestors
  param with valid query params (alerts, compact)
- Fix docs/api-reference.md: add url field to error result structure
- Fix docs/quota-management.md: correct extra parenthesis typo
- Fix docs/quota-management.md: update method name from createOrgFullScan
  to createFullScan throughout
- Fix types.ts: retries default is 3 (not 0), retryDelay is 1000 (not 100)
- Fix quota-management.md: remove non-existent createScanFromFilepaths method
- Fix quota-management.md: correct free method count from 43 to 44
- Add 'TB' to sizes array for terabyte-scale files
- Use Math.min to clamp index to prevent undefined access for files ≥1PB
@jdalton jdalton force-pushed the fix/quality-scan-improvements branch 2 times, most recently from 8f838f0 to 7dc7f16 Compare March 2, 2026 22:24
- Fix README.md: use correct depscore field from SocketPackageScore
- Fix api-reference.md: iterate result.data directly (not .packages)
- Fix api-reference.md: use scan_state field (not status)
- Fix validate-bundle-deps.mjs: return null for empty specifiers
@jdalton jdalton force-pushed the fix/quality-scan-improvements branch from 7dc7f16 to 5707cfd Compare March 2, 2026 23:06
@jdalton jdalton merged commit 664aecd into main Mar 3, 2026
9 checks passed
@jdalton jdalton deleted the fix/quality-scan-improvements branch March 3, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants