fix(test): pass --passWithNoTests to vitest#598
Open
John-David Dalton (jdalton) wants to merge 1 commit intomainfrom
Open
fix(test): pass --passWithNoTests to vitest#598John-David Dalton (jdalton) wants to merge 1 commit intomainfrom
John-David Dalton (jdalton) wants to merge 1 commit intomainfrom
Conversation
When a scoped test run (e.g. pre-commit hook with --staged) only touches files that don't map to any test, vitest exits 1 with "No test files found". That's a false positive — a scope producing zero matches should succeed, not fail the commit. Add --passWithNoTests so the exit code reflects test outcomes, not whether the pattern happened to match a file.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--staged, or any partial scope) only touches files that don't map to any test file,vitestexits with code 1 and "No test files found".--passWithNoTeststo the vitest args so the exit code reflects actual test outcomes.Test plan
pnpm teston a change that only touches non-test files (e.g. a README edit) no longer errorspnpm testthat does touch tests still runs and fails/passes correctly