Closed
Conversation
SoftCreatR
added
good first issue
Owner
|
Hey, thank you for your PR. Looks like I've accidentally disabled the issues section. As of now, this PR could not be merged. At least, because of the syntax error in line 32. But I'll leave this open for further improvements (and tests!) |
Author
|
Forgot a semicolon |
SoftCreatR
force-pushed
the
main
branch
15 times, most recently
from
619da93 to
b92df9a
Compare
Author
|
@SoftCreatR Are you thinking of merging this anytime soon? |
Owner
|
Tbh, that's way too incomplete to be merged. However, this PR counts towards your Hacktoberfest goal (just in case that you are participating). |
Author
|
@SoftCreatR Actually I already fulfilled it, and that is genuine suggestion |
Author
|
@SoftCreatR guide me to completion |
Owner
|
Well, the only code change here is the addition of a regular expression. There's currently no use for this regex and no test. It's currently just a proposal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the idea proposed within the code, I have commented the code for the indexing and added a regex for the multi index matching thanks for review in advance.