Skip to content

65 wizard-validation-error-message#121

Merged
khoadnguyen merged 21 commits intodevfrom
65-wizard-validation-erro-message
Oct 16, 2018
Merged

65 wizard-validation-error-message#121
khoadnguyen merged 21 commits intodevfrom
65-wizard-validation-erro-message

Conversation

@iamalx
Copy link
Copy Markdown
Collaborator

@iamalx iamalx commented Oct 15, 2018

65 @khoa, I included all of the questions for the 3 slides; conditionally validated the conditional questions!!! ; displayed error messages for the the questions that where touched or dirty and not validated; and user are only allowed to move to the next page if the validation form is validated and all of the radio alerts are validated.

I still need to validate the whole page for page #2 and #3, but I want to get your feedback on the first page

iamalx added 19 commits October 10, 2018 10:42
…3) =>started on nextButton disabled attribute to sync with form validation
…ng 'YES' on disability question by using 'setValidators()'
…o lockSwipe a page when in page 6 and form not valid
…ked ok w/o data by including 'else if(data === undefined ) clearValidators()'
…uded stutusChanges observable.. booth inputs are required
…g correctly => WIP: validator requirements in TS(logic)
…gic that checks if everything is valid, else it show error message for cards that are invalid
@iamalx iamalx added the code review This PR is ready for code review label Oct 15, 2018
@iamalx iamalx added this to the Week 5 milestone Oct 15, 2018
@iamalx iamalx self-assigned this Oct 15, 2018
@iamalx iamalx requested a review from khoadnguyen October 15, 2018 17:13
@khoadnguyen khoadnguyen merged commit 5d09d55 into dev Oct 16, 2018
@khoadnguyen khoadnguyen deleted the 65-wizard-validation-erro-message branch October 31, 2018 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code review This PR is ready for code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants