13 dashboard#21
Merged
khoadnguyen merged 3 commits intodevfrom Sep 25, 2018
Merged
Conversation
…shboard. Changed <ion-header> color in variables.scss in themes directory
Closed
khoadnguyen
approved these changes
Sep 24, 2018
Contributor
khoadnguyen
left a comment
khoadnguyen
left a comment
There was a problem hiding this comment.
Great job, good on the tagging and creating your PR. The file changes look good, but I noticed that you added something to variables.scss which is a global file. It would be good to note that in your PR in case anyone needed reference to it. Overall, good job though. 👍
Contributor
|
💃💃💃 -> (caused me extra effort) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed code for dashboard page styling and layout. Complete with ion-cards and the like