Skip to content

8 transition page#27

Merged
khoadnguyen merged 6 commits intodevfrom
8-transition-page
Sep 27, 2018
Merged

8 transition page#27
khoadnguyen merged 6 commits intodevfrom
8-transition-page

Conversation

@jal040
Copy link
Copy Markdown
Collaborator

@jal040 jal040 commented Sep 24, 2018

Created chart for results of self assessment test. Labels still need to be fixed and functionality needs to be worked on.

@jal040 jal040 added the code review This PR is ready for code review label Sep 24, 2018
@jal040 jal040 added this to the Week 2 milestone Sep 24, 2018
@jal040 jal040 self-assigned this Sep 24, 2018
@jal040 jal040 requested a review from khoadnguyen September 24, 2018 21:27
Copy link
Copy Markdown
Contributor

@khoadnguyen khoadnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason why timeline page changes are also a part of this branch? I think we need only the Transition page changes.

@jal040 jal040 mentioned this pull request Sep 25, 2018
@jal040 jal040 changed the base branch from master to dev September 25, 2018 02:38
@khoadnguyen khoadnguyen added the changes requested This PR needs changes before it can be approved. label Sep 25, 2018
@khoadnguyen khoadnguyen removed the changes requested This PR needs changes before it can be approved. label Sep 27, 2018
@khoadnguyen khoadnguyen merged commit 857cc80 into dev Sep 27, 2018
@khoadnguyen khoadnguyen deleted the 8-transition-page branch October 31, 2018 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code review This PR is ready for code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants