35 register validation#62
Merged
khoadnguyen merged 6 commits intodevfrom Oct 2, 2018
Merged
Conversation
… 35-register-validation
…inally just input tags with .input classes
…to invalid messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue 35
Completed form validation for all input fields except password confirmation. Still working on that one. Invalid highlights around input, invalid messages for inputs, and disabled register button for incomplete form are all styled.
issue 44
Fixed "INTRANSITION" text in .card-title header from exceeding width in ipad pro portrait mode. Need to discuss with Alex if resolution is acceptable.