Skip to content

changed styling to better match wireframes and removed buttons#42

Merged
khoadnguyen merged 1 commit intodevfrom
37-resultsPage-FinalizeView
Jul 24, 2018
Merged

changed styling to better match wireframes and removed buttons#42
khoadnguyen merged 1 commit intodevfrom
37-resultsPage-FinalizeView

Conversation

@McSheaKP
Copy link
Copy Markdown
Contributor

-Removed the respective buttons (navigation now associated with tabs)
-Moved charts and information template to be displayed in a card per style guide
-Changed header template to reflect the respective profile being displayed.

@McSheaKP McSheaKP added the code review This PR is ready for code review label Jul 21, 2018
@McSheaKP McSheaKP added this to the Week 2 milestone Jul 21, 2018
@McSheaKP McSheaKP requested a review from khoadnguyen July 21, 2018 23:39
@khoadnguyen
Copy link
Copy Markdown
Contributor

These changes look good too. 👍

Copy link
Copy Markdown
Contributor

@khoadnguyen khoadnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem good

@khoadnguyen khoadnguyen added reviewed This PR has been code reviewed and ready to merge and removed code review This PR is ready for code review labels Jul 23, 2018
@khoadnguyen khoadnguyen merged commit 087d5a8 into dev Jul 24, 2018
@khoadnguyen
Copy link
Copy Markdown
Contributor

Merged!

@khoadnguyen khoadnguyen added reviewed This PR has been code reviewed and ready to merge and removed code review This PR is ready for code review reviewed This PR has been code reviewed and ready to merge labels Jul 26, 2018
@khoadnguyen khoadnguyen deleted the 37-resultsPage-FinalizeView branch August 30, 2018 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewed This PR has been code reviewed and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants