Skip to content

25 landing page#43

Merged
khoadnguyen merged 2 commits intodevfrom
25-landingPage
Jul 24, 2018
Merged

25 landing page#43
khoadnguyen merged 2 commits intodevfrom
25-landingPage

Conversation

@McSheaKP
Copy link
Copy Markdown
Contributor

-Updated formatting of the page to be more in line with wireframe.
-Updated components in accordance with the style guide
-Added imports routing to the login and register buttons
-Added updated content

@McSheaKP McSheaKP added the code review This PR is ready for code review label Jul 21, 2018
@McSheaKP McSheaKP added this to the Week 2 milestone Jul 21, 2018
@McSheaKP McSheaKP requested a review from khoadnguyen July 21, 2018 23:45
@khoadnguyen
Copy link
Copy Markdown
Contributor

The changes look good! Good job outlining your commits and PR & thank you for tagging things appropriately. 👍

Copy link
Copy Markdown
Contributor

@khoadnguyen khoadnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@khoadnguyen khoadnguyen added reviewed This PR has been code reviewed and ready to merge and removed code review This PR is ready for code review labels Jul 23, 2018
@khoadnguyen khoadnguyen merged commit 8dd86fe into dev Jul 24, 2018
@khoadnguyen khoadnguyen added reviewed This PR has been code reviewed and ready to merge and removed code review This PR is ready for code review reviewed This PR has been code reviewed and ready to merge labels Jul 26, 2018
@khoadnguyen khoadnguyen deleted the 25-landingPage branch August 30, 2018 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewed This PR has been code reviewed and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants