Merged
Conversation
Contributor
|
I think we can remove all imports from The page changes look good though. |
khoadnguyen
suggested changes
Jul 23, 2018
Contributor
khoadnguyen
left a comment
khoadnguyen
left a comment
There was a problem hiding this comment.
Same issue, let's revisit these app.module imports in class.
khoadnguyen
approved these changes
Jul 24, 2018
Contributor
|
Thanks for making those changes! 👍 |
khoadnguyen
added
reviewed
khoadnguyen
added
reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Everything is added except validation/required. I was a little confused when researching. I need to investigate forms more so I can add the validation. I will connect with Nardos to help with direction on setting this part.