Conversation
Replaces ryu (max precision) with a %g-compatible formatter that produces identical output to htslib/bcftools: - 35.89775 → "35.8978" (6 significant digits) - 60.0 → "60" (drops trailing .0) - 0.777778 → "0.777778" - 99.0 → "99" (integer-like floats) This ensures seqair VCF text output is byte-compatible with htslib for float formatting, enabling precise output comparison. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
New VcfRecordBuilder methods that take &[i32] / &[f32] instead of Vec<Option<i32>> / Vec<Option<f32>> for the common case where all values are present (no missing). Wraps in Some internally. Eliminates verbose .iter().map(|&v| Some(v)).collect() at every call site in rastair's field translation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
InfoValue::IntegerArray, FloatArray, StringArray and SampleValue arrays now use SmallVec<T, 4> instead of Vec<T>. Per-allele arrays (typically 1-3 elements) are inline — no heap allocation. info_string() now accepts impl Display, allowing callers to pass any displayable type without manually converting to SmolStr. info_integer_array/info_float_array accept impl Into<SmallVec> for flexible construction from Vec, SmallVec, or array literals. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.