Mage: Prismatic Barrier

[fnordson]

Thanks for reviving the add-on.

Would it be possible to get back Prismatic Barrier for the mage again?
I've been using the scroll function to launch it during combat so I didn't have to look for it's cool down or use a button.
Now mages have even more spells and use even more buttons and it would be very useful.

[speedwaystar]

sure. another user had an issue with this, or was that you?

it's definitely in the code, so i'll double check that it's working as intended

[speedwaystar]

can you give me some more info about what exactly is happening? is it not appearing in your buff list? is it not prompting you to cast when it's ticked? is it not working in combat?
tested with and without Improved Prismatic Barrier talent. seems to be working fine.

[fnordson]

It is not appearing my my buff list at all anymore.
As you can see in the screenshot it should be there as I can cast it.

Edit: Same issue with the version you've uploaded 8h ago:

[speedwaystar]

downloading the 7gb deDE localization now...

[speedwaystar]

hmmm


at this point i really have no idea why your version isn't working, sorry

[speedwaystar]

my current alpha is very different from the release and is not at all ready for public consumption, but i might send you a copy once i've fixed a few things which are actively breaking it and you can let me know if Prismatic Barrier works in the alpha.
i'm not sure if you've mentioned this before, but do try running with all other addons switched off, because one of the very few possible reasons for this kind of bug that i can think of is another addon polluting the shared global namespace.

[fnordson]

Sorry I forgot to write that above: I tried turning all other addons off.
I just tried again with the newer version (See screenshot in comment above).
I also deleted related files in SavedVariables.
Unfortunately it didn't help.

FYI: your smart buff addon worked with prismatic barrier once in Dragonflight.
It stopped after one of the updates. I just didn't write a bug report because I thought I might play without it.

I'd appreciate your alpha.

[speedwaystar]

from discord user Mokay:
https://discord.com/channels/697774223833170000/864095814950977557/1066432962582806548
I figured out why the mage barriers gone missing. As you get more active spells from the talents the barriers move down the spelltabs book count and the addon does not grasp them because the API GetNumSpellTabs only gets the visible tabs but there are some hidden before the specialization tabs and there are a lot more spells before the barriers. I was getting just the first 122 spells when there are more than 200, and the barriers are at the 130's.
I changed function SMARTBUFF_GetSpellID, and instead of getting the number of spells with GetNumSpellTab() and GetSpellTabInfo(), I changed it to:
local i = 1;
while GetSpellBookItemName(i, BOOKTYPE_SPELL) do
i = i + 1;
end
nSpells = i;
And I got my barriers back.
Reference: https://wowpedia.fandom.com/wiki/API_GetSpellTabInfo
There is a note almost at the end mentioning that not all spells available from the API are shown in the spellbook

[speedwaystar]

sorry @fnordson can you reopen the ticket? it hasn't been fixed internally yet. we'll close it when fix is pushed to the main release. cheers.

[fnordson]

It works!
Thank you :)

[speedwaystar]

cheers! you can close the ticket now :D