Reset buffs, not UI settings on new releases#54
Merged
Softrix merged 2 commits intoSoftrix:mainfrom Nov 18, 2024
Merged
Conversation
More nil checks
Collaborator
Author
|
This got released to retail curse. but i would appreciate a look over or a chat later. it's a little hacky to be fair. does seem to work so maybe okay? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't understand reason to reset all the GUI settings in addition to buffs on version changes since gui is reset by UI reload
Changing to buff reset only instead of full reset
No more extra UI reload on new version changes
No more anti-daze for hunters
Bug fixes for nil data on certain buffs being stale in db
Basic localization for new prompt
Nit fixes.