Bugfix and consistency rename#96
Merged
Merged
Conversation
ynazar1
force-pushed
the
bugfix_and_consistency_rename
branch
from
89c2be7 to
a9a2c85
Compare
This commit is on top of main (e.g. hide action button when idle is already there from Softrix#95). It only adds template table / getCurrentTemplate hardening, addon-wide function renames, XML handler alignment, and small loader fixes — not the hide-when-idle feature. - Document SMARTBUFF_* globals vs camelCase locals in .cursorrules - Rename addon globals to SMARTBUFF_PascalCase; sync SmartBuff.xml and call sites - Rename file-local helpers to camelCase (SmartBuff.lua, SmartBuff.buffs.lua) - Harden buff settings when template/state is unset (getCurrentTemplate, ensureBuffsTemplateTable, buffsTemplateTable) - SmartBuff.globals.lua: prefixed debug helpers; Enum uses table.invert (fix undefined tInvert) - XML/Lua: SMARTBUFF_BuffOrderOnScroll / ScheduleBuffOrderOnScroll casing Co-authored-by: Cursor <cursoragent@cursor.com>
ynazar1
force-pushed
the
bugfix_and_consistency_rename
branch
from
a9a2c85 to
37edec8
Compare
Add smartBuffTemplateForGroupKey() so SMARTBUFF_TEMPLATES is never indexed with a nil enum slot (avoids field '?' errors). Route getCurrentTemplate, SetTemplate autoswitch, and template comparisons through the helper; keep numeric templateLookup indices unchanged. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.