Skip to content

Expanding rules with explicit definitions of values#134

Merged
elliot-huffman merged 4 commits intomainfrom
feature-improve-rule
Sep 17, 2025
Merged

Expanding rules with explicit definitions of values#134
elliot-huffman merged 4 commits intomainfrom
feature-improve-rule

Conversation

@pasha-zayko
Copy link
Copy Markdown
Contributor

Adding exception option to the rule to ignore variables starting with underscore

Updating several packages to the latest versions

Adding exception option to the rule to ignore variables starting with underscore

Updating several packages to the latest versions
@pasha-zayko pasha-zayko self-assigned this Sep 9, 2025
Copilot AI review requested due to automatic review settings September 9, 2025 19:02
@pasha-zayko pasha-zayko added the enhancement New feature or request label Sep 9, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR expands the no-unused-vars ESLint rule configuration and updates several development dependencies to their latest versions. The main enhancement adds an exception pattern to ignore variables starting with underscore, following common conventions for intentionally unused variables.

  • Added argsIgnorePattern configuration to ignore unused variables prefixed with underscore
  • Updated ESLint and related plugins to newer versions
  • Bumped package version from 1.0.5 to 1.0.6

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
package.json Version bump and dependency updates for ESLint ecosystem packages
config/baseLintConfig.ts Added underscore prefix pattern to ignore unused variables in ESLint rule

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Sep 9, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednext@​15.5.0 ⏵ 15.5.383 +210091 +198 +170
Updatedmocha@​11.7.1 ⏵ 11.7.2971009593100
Updatedeslint@​9.34.0 ⏵ 9.35.097 +110010095 -1100
Updatedeslint-plugin-jsdoc@​54.1.1 ⏵ 57.0.899 +110010096 +2100

View full report

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Sep 9, 2025

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
@es-joy/jsdoccomment@0.58.0 has a License Policy Violation.

Location: Package overview

From: package-lock.jsonnpm/eslint-plugin-jsdoc@57.0.8npm/@es-joy/jsdoccomment@0.58.0

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@es-joy/jsdoccomment@0.58.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
@eslint-community/eslint-utils@4.9.0 has a License Policy Violation.

Location: Package overview

From: package-lock.jsonnpm/@stylistic/eslint-plugin@5.2.3npm/typescript-eslint@8.40.0npm/eslint@9.35.0npm/@eslint-community/eslint-utils@4.9.0

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@eslint-community/eslint-utils@4.9.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
@eslint/js@9.35.0 has a License Policy Violation.

Location: Package overview

From: package-lock.jsonnpm/eslint@9.35.0npm/@eslint/js@9.35.0

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@eslint/js@9.35.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
@next/env@15.5.3 has a License Policy Violation.

Location: Package overview

From: package-lock.jsonnpm/next@15.5.3npm/@next/env@15.5.3

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@next/env@15.5.3. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
@next/swc-darwin-arm64@15.5.3 has a License Policy Violation.

Location: Package overview

From: package-lock.jsonnpm/next@15.5.3npm/@next/swc-darwin-arm64@15.5.3

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@next/swc-darwin-arm64@15.5.3. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
@next/swc-darwin-x64@15.5.3 has a License Policy Violation.

Location: Package overview

From: package-lock.jsonnpm/next@15.5.3npm/@next/swc-darwin-x64@15.5.3

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@next/swc-darwin-x64@15.5.3. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
@next/swc-linux-arm64-gnu@15.5.3 has a License Policy Violation.

Location: Package overview

From: package-lock.jsonnpm/next@15.5.3npm/@next/swc-linux-arm64-gnu@15.5.3

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@next/swc-linux-arm64-gnu@15.5.3. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
@next/swc-linux-arm64-musl@15.5.3 has a License Policy Violation.

Location: Package overview

From: package-lock.jsonnpm/next@15.5.3npm/@next/swc-linux-arm64-musl@15.5.3

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@next/swc-linux-arm64-musl@15.5.3. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
@next/swc-linux-x64-gnu@15.5.3 has a License Policy Violation.

Location: Package overview

From: package-lock.jsonnpm/next@15.5.3npm/@next/swc-linux-x64-gnu@15.5.3

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@next/swc-linux-x64-gnu@15.5.3. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
@next/swc-linux-x64-musl@15.5.3 has a License Policy Violation.

Location: Package overview

From: package-lock.jsonnpm/next@15.5.3npm/@next/swc-linux-x64-musl@15.5.3

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@next/swc-linux-x64-musl@15.5.3. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
@next/swc-win32-arm64-msvc@15.5.3 has a License Policy Violation.

Location: Package overview

From: package-lock.jsonnpm/next@15.5.3npm/@next/swc-win32-arm64-msvc@15.5.3

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@next/swc-win32-arm64-msvc@15.5.3. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
@next/swc-win32-x64-msvc@15.5.3 has a License Policy Violation.

Location: Package overview

From: package-lock.jsonnpm/next@15.5.3npm/@next/swc-win32-x64-msvc@15.5.3

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@next/swc-win32-x64-msvc@15.5.3. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
@typescript-eslint/types@8.43.0 has a License Policy Violation.

Location: Package overview

From: package-lock.jsonnpm/@stylistic/eslint-plugin@5.2.3npm/typescript-eslint@8.40.0npm/eslint-plugin-jsdoc@57.0.8npm/@typescript-eslint/types@8.43.0

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@typescript-eslint/types@8.43.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
debug@4.4.3 has a License Policy Violation.

Location: Package overview

From: package-lock.jsonnpm/typescript-eslint@8.40.0npm/mocha@11.7.2npm/eslint@9.35.0npm/eslint-plugin-jsdoc@57.0.8npm/debug@4.4.3

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/debug@4.4.3. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
eslint-plugin-jsdoc@57.0.8 has a License Policy Violation.

Location: Package overview

From: package-lock.jsonnpm/eslint-plugin-jsdoc@57.0.8

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/eslint-plugin-jsdoc@57.0.8. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
eslint@9.35.0 has a License Policy Violation.

Location: Package overview

From: package-lock.jsonnpm/eslint@9.35.0

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/eslint@9.35.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
jsdoc-type-pratt-parser@5.4.0 has a License Policy Violation.

Location: Package overview

From: package-lock.jsonnpm/eslint-plugin-jsdoc@57.0.8npm/jsdoc-type-pratt-parser@5.4.0

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/jsdoc-type-pratt-parser@5.4.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
mocha@11.7.2 has a License Policy Violation.

Location: Package overview

From: package-lock.jsonnpm/mocha@11.7.2

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/mocha@11.7.2. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
next@15.5.3 has a License Policy Violation.

License: MPL-2.0 (package/dist/compiled/@vercel/og/LICENSE)

License: CC-BY-SA-4.0 (package/dist/compiled/glob/LICENSE)

License: MPL-2.0 (package/dist/compiled/@vercel/og/satori/LICENSE)

License: MPL-2.0 (package/dist/compiled/@vercel/og/package.json)

From: package-lock.jsonnpm/next@15.5.3

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/next@15.5.3. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
object-deep-merge@1.0.5 has a License Policy Violation.

Location: Package overview

From: package-lock.jsonnpm/eslint-plugin-jsdoc@57.0.8npm/object-deep-merge@1.0.5

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/object-deep-merge@1.0.5. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
type-fest@4.2.0 has a License Policy Violation.

Location: Package overview

From: package-lock.jsonnpm/eslint-plugin-jsdoc@57.0.8npm/type-fest@4.2.0

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/type-fest@4.2.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Medium
object-deep-merge@1.0.5 is a AI-detected possible typosquat.

Did you mean: object-~~deep-~~merge

From: package-lock.jsonnpm/eslint-plugin-jsdoc@57.0.8npm/object-deep-merge@1.0.5

ℹ Read more on: This package | This alert | What is AI-detected potential typosquatting?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Given the AI system's identification of this package as a potential typosquat, please verify that you did not intend to install a different package. Be cautious, as malicious packages often use names similar to popular ones.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/object-deep-merge@1.0.5. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Updating packages to the latest versions to match dependabot suggestions
Explicitly define rules around where and how many repeated empty lines can appear in the files:
- no line at the start of the file
- 1 line at the end of the file
- 1 repeated line maximum inside file content
@pasha-zayko pasha-zayko changed the title Expanding rule no-unused-vars Expanding rules with explicit definitions of values Sep 16, 2025
Copy link
Copy Markdown
Contributor

@elliot-huffman elliot-huffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@elliot-huffman elliot-huffman merged commit 9ab14e5 into main Sep 17, 2025
9 checks passed
@elliot-huffman elliot-huffman deleted the feature-improve-rule branch September 17, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants