LAB-1874 - Fix OpenAPI spec for Kiota limitation.#138
Merged
ferrywlto merged 2 commits intofeature/LAB-611_CMA_Endpoints_Descriptionsfrom Mar 27, 2026
Merged
Conversation
Base automatically changed from
LAB-1735-implement-internal-external-user-branching-logic
to
feature/LAB-611_CMA_Endpoints_Descriptions
March 27, 2026 15:59
There was a problem hiding this comment.
Pull request overview
Refactors the Data Gateway OpenAPI spec to reduce duplication and improve Kiota compatibility by standardizing nullable UUID and date-time fields via shared component schemas.
Changes:
- Updated
NullableUuidandNullableDateTimeStringTypeto usetype: ["string", "null"](instead ofoneOf+null). - Replaced several inline nullable UUID/date-time property schemas with
$refreferences to the shared components. - Minor normalization in the
Uuidschema field ordering (no functional change intended).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JagdishKhunti
approved these changes
Mar 27, 2026
02423e2
into
feature/LAB-611_CMA_Endpoints_Descriptions
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the OpenAPI schema definitions in
specs/Data-Gateway.jsonto improve consistency and reusability of nullable UUID and date-time fields. Instead of repeating type definitions for each property, the schema now references shared components for nullable UUIDs and nullable date-time strings. This change reduces duplication and makes the schema easier to maintain.Schema refactoring and standardization:
NullableUuidandNullableDateTimeStringTypeschema components to use a more concisetype: ["string", "null"]format, and added relevant constraints and descriptions. [1] [2]breakoutId,expiryDate,replacementDate,discoveryDate,accountId,createdDate, andmodifiedDate) to reference the new shared schema components, reducing redundancy across the spec. [1] [2] [3] [4] [5] [6]