Skip to content

LAB-1874 - Fix OpenAPI spec for Kiota limitation.#138

Merged
ferrywlto merged 2 commits intofeature/LAB-611_CMA_Endpoints_Descriptionsfrom
fix/nullable-primitive-types
Mar 27, 2026
Merged

LAB-1874 - Fix OpenAPI spec for Kiota limitation.#138
ferrywlto merged 2 commits intofeature/LAB-611_CMA_Endpoints_Descriptionsfrom
fix/nullable-primitive-types

Conversation

@ferrywlto
Copy link
Copy Markdown
Contributor

This pull request refactors the OpenAPI schema definitions in specs/Data-Gateway.json to improve consistency and reusability of nullable UUID and date-time fields. Instead of repeating type definitions for each property, the schema now references shared components for nullable UUIDs and nullable date-time strings. This change reduces duplication and makes the schema easier to maintain.

Schema refactoring and standardization:

  • Introduced and updated the NullableUuid and NullableDateTimeStringType schema components to use a more concise type: ["string", "null"] format, and added relevant constraints and descriptions. [1] [2]
  • Updated all properties previously using inline nullable UUID or date-time definitions (such as breakoutId, expiryDate, replacementDate, discoveryDate, accountId, createdDate, and modifiedDate) to reference the new shared schema components, reducing redundancy across the spec. [1] [2] [3] [4] [5] [6]

Copilot AI review requested due to automatic review settings March 27, 2026 15:58
Base automatically changed from LAB-1735-implement-internal-external-user-branching-logic to feature/LAB-611_CMA_Endpoints_Descriptions March 27, 2026 15:59
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the Data Gateway OpenAPI spec to reduce duplication and improve Kiota compatibility by standardizing nullable UUID and date-time fields via shared component schemas.

Changes:

  • Updated NullableUuid and NullableDateTimeStringType to use type: ["string", "null"] (instead of oneOf + null).
  • Replaced several inline nullable UUID/date-time property schemas with $ref references to the shared components.
  • Minor normalization in the Uuid schema field ordering (no functional change intended).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ferrywlto ferrywlto marked this pull request as ready for review March 27, 2026 16:04
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ferrywlto ferrywlto merged commit 02423e2 into feature/LAB-611_CMA_Endpoints_Descriptions Mar 27, 2026
6 checks passed
@ferrywlto ferrywlto deleted the fix/nullable-primitive-types branch March 27, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants