Skip to content

LAB-980 #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JagdishKhunti merged 7 commits into from
Dec 3, 2025
Merged

LAB-980 #71

JagdishKhunti merged 7 commits into from
Dec 3, 2025

Conversation

@JagdishKhunti
Copy link

@JagdishKhunti JagdishKhunti commented Nov 21, 2025

  • Added endpoint and schema descriptions for LicenseReportV1
  • Extracted common schema into a shared object for reuse in both LicenseReport and LicenseReportV1

@JagdishKhunti
LAB-980
a56e847 
- Added endpoint and schema descriptions for LicenseReportV1
- Extracted common schema into a shared object for reuse in both LicenseReport and LicenseReportV1
pasha-zayko
pasha-zayko reviewed Nov 21, 2025
View reviewed changes
pasha-zayko
pasha-zayko reviewed Nov 21, 2025
View reviewed changes
pasha-zayko
pasha-zayko reviewed Nov 21, 2025
View reviewed changes
pasha-zayko
pasha-zayko reviewed Nov 21, 2025
View reviewed changes
pasha-zayko
pasha-zayko reviewed Nov 21, 2025
View reviewed changes
pasha-zayko
pasha-zayko reviewed Nov 21, 2025
View reviewed changes
pasha-zayko
pasha-zayko reviewed Nov 21, 2025
View reviewed changes
pasha-zayko
pasha-zayko reviewed Nov 21, 2025
View reviewed changes
pasha-zayko
pasha-zayko reviewed Nov 21, 2025
View reviewed changes
pasha-zayko
pasha-zayko reviewed Nov 21, 2025
View reviewed changes
pasha-zayko
pasha-zayko reviewed Nov 21, 2025
View reviewed changes
pasha-zayko
pasha-zayko reviewed Nov 21, 2025
View reviewed changes
pasha-zayko
pasha-zayko reviewed Nov 21, 2025
View reviewed changes
pasha-zayko
pasha-zayko requested changes Nov 21, 2025
View reviewed changes
Copy link
Contributor

@pasha-zayko pasha-zayko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes commented on, but also the repeated pattern of the same type of missing items that should be corrected in the rest of the implementation.

@JagdishKhunti
Refactor license report schemas and enhance docs
056e96d 
Renamed LicenseReportV1 schemas to Report.* for consistency and updated all references. Added detailed descriptions, examples, and validation patterns to license, principal, and service plan fields. Improved API response codes and documentation for error handling and deletion endpoints.
@JagdishKhunti
Update Data-Gateway.json
0bd0f0d
pasha-zayko
pasha-zayko reviewed Dec 1, 2025
View reviewed changes
pasha-zayko
pasha-zayko reviewed Dec 1, 2025
View reviewed changes
pasha-zayko
pasha-zayko reviewed Dec 1, 2025
View reviewed changes
pasha-zayko
pasha-zayko reviewed Dec 1, 2025
View reviewed changes
pasha-zayko
pasha-zayko reviewed Dec 1, 2025
View reviewed changes
pasha-zayko
pasha-zayko reviewed Dec 1, 2025
View reviewed changes
pasha-zayko
pasha-zayko reviewed Dec 1, 2025
View reviewed changes
pasha-zayko
pasha-zayko reviewed Dec 1, 2025
View reviewed changes
pasha-zayko
pasha-zayko reviewed Dec 1, 2025
View reviewed changes
pasha-zayko
pasha-zayko reviewed Dec 1, 2025
View reviewed changes
pasha-zayko
pasha-zayko reviewed Dec 1, 2025
View reviewed changes
pasha-zayko
pasha-zayko reviewed Dec 1, 2025
View reviewed changes
pasha-zayko
pasha-zayko requested changes Dec 1, 2025
View reviewed changes
Copy link
Contributor

@pasha-zayko pasha-zayko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several outstanding items to adjust

@JagdishKhunti
LAB-980
424c5fd 
Updated the Data-Gateway JSON schema to clarify and expand user and device principal records, including required fields and more detailed property definitions. Enhanced the structure and examples for inferred attributes and enhanced identity data, added explicit nullability, and improved descriptions for service plan and license references. These changes improve schema accuracy and documentation for integrators.
@pasha-zayko pasha-zayko requested a review from Copilot December 2, 2025 16:20
Copilot AI reviewed Dec 2, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JagdishKhunti
LAB-980
3d2e0a2 
Refactored user and device principal data schemas to use new CommonService, AssignedLicense, and PrincipalMetadata references under Report.PrincipalData. Simplified nullable property definitions and examples. Added 500 error responses to multiple API endpoints for improved error handling.
@JagdishKhunti
LAB-987
f9faf37 
Revised the structure of the 'examples' field for assigned licenses, wrapping multiple example objects in an array and adding a new example. This improves consistency and clarity in the API specification.
pasha-zayko
pasha-zayko reviewed Dec 2, 2025
View reviewed changes
pasha-zayko
pasha-zayko reviewed Dec 2, 2025
View reviewed changes
pasha-zayko
pasha-zayko reviewed Dec 2, 2025
View reviewed changes
pasha-zayko
pasha-zayko reviewed Dec 2, 2025
View reviewed changes
pasha-zayko
pasha-zayko requested changes Dec 2, 2025
View reviewed changes
Copy link
Contributor

@pasha-zayko pasha-zayko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there, just a couple of final adjustments needed

@JagdishKhunti
LAB-980
381385a 
Refactored and expanded example objects for available licenses, users, and devices to improve clarity and coverage. Adjusted nesting and array structures for consistency and added additional sample entries to better illustrate expected data formats.
@JagdishKhunti JagdishKhunti merged commit 228bd67 into LAB-938-CSPM-main Dec 3, 2025
2 checks passed
@JagdishKhunti JagdishKhunti deleted the feature/LAB-980_Describe-V1-LicenseReport-API-Endpoints branch December 3, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@pasha-zayko pasha-zayko pasha-zayko approved these changes

Assignees

@JagdishKhunti JagdishKhunti

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JagdishKhunti @pasha-zayko