Merge with upstream#1
Merged
SatyamBhawsinghka merged 10 commits intoSoftwareDevEngResearch:mainfrom Mar 7, 2022
Merged
Conversation
Xin-yang-Liu
suggested changes
Mar 7, 2022
Xin-yang-Liu
left a comment
Xin-yang-Liu
left a comment
There was a problem hiding this comment.
This project is very impressive and achieved the goals stated in the README.md. Here I have some suggestions for you.
- If the
.csv,.gif,.bmpfiles are generated by the program, please consider adding them to the .gitignore. (You may not want to use git to track all the output files) - I am not familiar with the algorithms you used in the c_first_order.py, but looks like you could vectorize (and dramatically accelerate) the function
calculate. For example, from line 101 to line 126, all the elements used to assemble the matrixmarrseems to share the same generation algorithms. You can replace this part with element-wise matrix operations provided bynumpy - It would be better if you could add comments to the code to help others understand and make future maintenance easier.
SatyamBhawsinghka
added a commit
that referenced
this pull request
Mar 8, 2022
* Adding first draft files * Adding first draft files * Making creating_deformation.py * Removing parallel implementation code * Adding all Files * Adding all files * Updating dic and c_first_order test files * Adding space in visualization * Adding output files * Update README.md * Merge with upstream (#1) Adding all Files * Delete temp.bmp * Delete temp.bmp * restructuring * Removing unrequired dependancies * Adding to gitignore * Delete Functions../generated/image/ref directory * Editing test files
SatyamBhawsinghka
added a commit
that referenced
this pull request
Mar 15, 2022
* Update README.md * Adding first draft files * Adding first draft files * Making creating_deformation.py * Removing parallel implementation code * Adding all Files * Adding all files * Updating dic and c_first_order test files * Adding space in visualization * Adding output files * Update README.md * Merge with upstream (#1) Adding all Files * Delete temp.bmp * Delete temp.bmp * restructuring * Removing unrequired dependancies * Adding to gitignore * Delete Functions../generated/image/ref directory * Editing test files * Adding comments and docstrings * Adding comments and docstrings * Adding sphinx final * Adding sphinx final * Adding sphinx final * Removing unrequired dependancies * Adding files for CI and testing * Adding status badge to readme * Debug * Debug * Debug * Debug * Restructuring * debug
SatyamBhawsinghka
added a commit
that referenced
this pull request
Mar 16, 2022
* Update README.md * Adding first draft files * Adding first draft files * Making creating_deformation.py * Removing parallel implementation code * Adding all Files * Adding all files * Updating dic and c_first_order test files * Adding space in visualization * Adding output files * Update README.md * Merge with upstream (#1) Adding all Files * Delete temp.bmp * Delete temp.bmp * restructuring * Removing unrequired dependancies * Adding to gitignore * Delete Functions../generated/image/ref directory * Editing test files * Adding comments and docstrings * Adding comments and docstrings * Adding sphinx final * Adding sphinx final * Adding sphinx final * Removing unrequired dependancies * Adding files for CI and testing * Adding status badge to readme * Debug * Debug * Debug * Debug * Restructuring * debug * restructuring * restructuring * Adding files for setup * Adding files for setup * Adding files for setup * updating README * updating README * updating README * updating README * updating README * debug * restructuring * Update README.md * restructuring * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * Update README * debug * debug * Update README * Final README
SatyamBhawsinghka
added a commit
that referenced
this pull request
Mar 16, 2022
* Update README.md * Adding first draft files * Adding first draft files * Making creating_deformation.py * Removing parallel implementation code * Adding all Files * Adding all files * Updating dic and c_first_order test files * Adding space in visualization * Adding output files * Update README.md * Merge with upstream (#1) Adding all Files * Delete temp.bmp * Delete temp.bmp * restructuring * Removing unrequired dependancies * Adding to gitignore * Delete Functions../generated/image/ref directory * Editing test files * Adding comments and docstrings * Adding comments and docstrings * Adding sphinx final * Adding sphinx final * Adding sphinx final * Removing unrequired dependancies * Adding files for CI and testing * Adding status badge to readme * Debug * Debug * Debug * Debug * Restructuring * debug * restructuring * restructuring * Adding files for setup * Adding files for setup * Adding files for setup * updating README * updating README * updating README * updating README * updating README * debug * restructuring * Update README.md * restructuring * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * Update README * debug * debug * Update README * Final README * Update README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.