Skip to content

#15 Login's ToggleButton inverted #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2019
Merged

#15 Login's ToggleButton inverted #16

merged 1 commit into from
Jul 11, 2019

Conversation

@victorvicari
Copy link
Contributor

@victorvicari victorvicari commented Jul 10, 2019

I've just inverted the textOff - textOn content properties

software_engineering_daily_login

@MostafaGazar
Copy link
Contributor

MostafaGazar commented Jul 10, 2019

Looks good, can you change your pull request to target develop instead of master? And we will merge into master when we do the next release.

@victorvicari victorvicari changed the base branch from master to develop July 10, 2019 20:19
@MostafaGazar MostafaGazar merged commit c7d9576 into SoftwareEngineeringDaily:develop Jul 11, 2019
@victorvicari victorvicari deleted the Login's_ToggleButton_inverted branch July 17, 2019 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MostafaGazar MostafaGazar Awaiting requested review from MostafaGazar

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@victorvicari @MostafaGazar