#12 Add pull to refresh support to bookmarks screen #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogress bar. Using the same fetch method, now it's possible to update too.
Contributor
|
Thanks Victor for your contribution, much appreciated. I will add a few comments to you PR later |
MostafaGazar
suggested changes
Jul 16, 2019
app/src/main/java/com/koalatea/sedaily/feature/bookmarks/BookmarksFragment.kt
Outdated
Show resolved
Hide resolved
MostafaGazar
suggested changes
Jul 16, 2019
Moved the tool's visibility from epoxyRecycler to bookmarkSwipeToRefresh
MostafaGazar
approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the
swipeToRefreshview into thebookmarklayout, and removed theprogressBar. Using the samefetchBookmarksmethod, now it's possible to update too.Fix for #12