#17 Upvoting Comments and Replies #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngDaily/develop Release v1.0.1
…ngDaily/develop Release v1.0.2
…wnvote comments on episodes.
MostafaGazar
suggested changes
Aug 8, 2019
app/src/main/java/com/koalatea/sedaily/feature/commentList/CommentsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/koalatea/sedaily/feature/commentList/CommentsViewModel.kt
Outdated
Show resolved
Hide resolved
.../main/java/com/koalatea/sedaily/feature/commentList/epoxy/BaseCommentEpoxyModelWithHolder.kt
Outdated
Show resolved
Hide resolved
.../main/java/com/koalatea/sedaily/feature/commentList/epoxy/BaseCommentEpoxyModelWithHolder.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/koalatea/sedaily/feature/commentList/epoxy/CommentEpoxyModelWithHolder.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/koalatea/sedaily/feature/commentList/epoxy/CommentsEpoxyController.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/koalatea/sedaily/feature/commentList/epoxy/CommentsEpoxyController.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/koalatea/sedaily/feature/commentList/epoxy/ReplyEpoxyModelWithHolder.kt
Outdated
Show resolved
Hide resolved
Justin-Terry
commented
Aug 10, 2019
Contributor
Author
Justin-Terry
left a comment
Justin-Terry
left a comment
There was a problem hiding this comment.
I've made the changes that were requested. Thank you for the tips and the help! Please let me know if there are any other mistakes I need to fix.
MostafaGazar
suggested changes
Aug 16, 2019
Contributor
MostafaGazar
left a comment
MostafaGazar
left a comment
There was a problem hiding this comment.
Just some minor small change requested
app/src/main/java/com/koalatea/sedaily/feature/commentList/epoxy/CommentEpoxyModelWithHolder.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/koalatea/sedaily/feature/commentList/epoxy/CommentEpoxyModelWithHolder.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/koalatea/sedaily/feature/commentList/epoxy/CommentEpoxyModelWithHolder.kt
Show resolved
Hide resolved
app/src/main/java/com/koalatea/sedaily/feature/commentList/epoxy/CommentEpoxyModelWithHolder.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/koalatea/sedaily/feature/commentList/epoxy/ReplyEpoxyModelWithHolder.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/koalatea/sedaily/repository/CommentsRepository.kt
Outdated
Show resolved
Hide resolved
Contributor
Author
|
I've made the requested changes. Thank you for your patience! |
Contributor
|
Thanks @Justin-Terry for working on #17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first shot at open source so if I've made mistakes please let me know!
I've added the ability for users to upvote/downvote comments and replies.