Skip to content

Conversation

@wufniks
Copy link
Contributor

@wufniks wufniks commented Aug 17, 2025

๐Ÿ› ๏ธ PR Summary

๐ŸŒŸ ์š”์•ฝ

์–ด๋–ค ๊ฒƒ์ด ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? ๊ฐ„๋žตํžˆ ์„ค๋ช…ํ•ด์ฃผ์„ธ์š”.

safe_divide ํ•จ์ˆ˜๋ฅผ ์œ„ํ•œ import๊ฐ€ ๋ˆ„๋ฝ๋˜์–ด ์žˆ์—ˆ๋Š”๋ฐ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ“Š ์ฃผ์š” ๋ณ€๊ฒฝ ์‚ฌํ•ญ

์ฃผ์š” ๋ณ€๊ฒฝ ์‚ฌํ•ญ์„ ์ ์–ด์ฃผ์„ธ์š”.

  • ๋ˆ„๋ฝ๋œ safe_divide์˜ import๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐ŸŽฏ ๋ชฉ์  ๋ฐ ์˜ํ–ฅ

  • ๋ชฉ์ : ์™œ ์ด PR์ด ํ•„์š”ํ•œ๊ฐ€์š”?
    ์ •์ƒ์ ์œผ๋กœ pykis/api/account/order_profit.py์ด ๋™์ž‘ํ•ฉ๋‹ˆ๋‹ค.

  • ์˜ํ–ฅ: ์ด ๋ณ€๊ฒฝ ์‚ฌํ•ญ์ด ์–ด๋–ค ์˜ํ–ฅ์„ ๋ฏธ์น˜๋‚˜์š”?
    ์ •์ƒ์ ์œผ๋กœ pykis/api/account/order_profit.py์ด ๋™์ž‘ํ•ฉ๋‹ˆ๋‹ค.

@Soju06 Soju06 merged commit 6fcde3f into Soju06:main Sep 5, 2025
1 check passed
Copy link
Owner

@Soju06 Soju06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Soju06 Soju06 added the ๋ฒ„๊ทธ ๋ญ”๊ฐ€ ์ž‘๋™ํ•˜์ง€ ์•Š์Šต๋‹ˆ๋‹ค. label Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

๋ฒ„๊ทธ ๋ญ”๊ฐ€ ์ž‘๋™ํ•˜์ง€ ์•Š์Šต๋‹ˆ๋‹ค.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants