Cleanup#6
Merged
Merged
Conversation
…every `BlockEntity` that implements `GasProviderData`
…ripheral` for sake of function parity
…hods for documentation but they call to their original for feature parity
…tachedComputerHandler` for `AttachedComputerSet` due to the wrapper class not being needed for this addon
…apply to all `KineticBlockEntity` instances that do not already have a peripheral
…and stable gas-type strings
10 SCADA methods (selfId/sourceId/networkId/kind/speed/stress/...) now declared once on the KineticScadaSurface interface as @LuaFunction default methods, implemented by both KineticPeripheral and SimKineticPeripheral via a single-line scadaBlockEntity() accessor. No more triplicated wrappers. Also restores the four Create-side SCADA wrappers (CreativeMotor, SpeedController, SpeedGauge, StressGauge) that the earlier deletes removed: the KineticSource generic only composes onto bare BlockEntities without an existing IPeripheral, so blocks that Create or Avionics already wraps need the SCADA pack via inheritance. Bare kinetic BEs (encased shafts, gearboxes, mixers) still get SCADA via KineticSource. Bumps cct-javadoc to 1.10.0-mainthread.4, which adds interface scanning so the doclet picks up @LuaFunction default methods on interfaces.
Owner
|
I have temporarily restored the create stuff, so that the docs do not degrade, but I'm exploring other solutions. Otherwise, LGTM, merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, I was informed that your addon exists! I think its a great expansion of existing peripherals!
However, you do many unnecessary things and duplicate a LOT of work you didnt need to, so I am here to rectify it all!
Aeronautics
GasProviderPeripheralGenericSource, not a standalone peripheral. Being a generic means that it will co-existing with other generics (inventory,fluid,energy) as well as apply to everyBlockEntitythat implementsGasProviderDatawithout needing explicit support!Simulated
AltitudeSensorPeripheralAltltudeSensorPeripheralextend the original and kept in your methods for proper documentation. This, in and of itself, will likely be a fix for many of your peripherals from the look of it.DirectionalLinkPeripheralGimbalSensorPeripheralAltitudeSensorPeripheralLinkedTypewriterPeripheralAttachedComputerHandleras that was simply a wrapper class used to avoid loading CC: Tweaked classes when CC: Tweaked wasnt installed. But your addon needs no such protections. Also,LinkedTypewriterPeripheralotherwise was a duplicate of the original.ModulatingLinkPeripheralNamePlatePeripheralNavTablePeripheralOpticalSensorPeripheralSwivelBearingPeripheralSimKineticPeripheral, not fixable at the momentTorsionSpringPeripheralSimKineticPeripheral, not fixable at the momentVelocitySensorPeripheralAltitudeSensorPeripheralSimKineticPeripheralSwivelBearingPeripheralandTorsionSpringPeripheralstill using it, I have also name aKineticSourcegeneric similar toGasProviderSourceso allKineticBlockEntityinstances will have these methods except for those which currently have peripheralsCreate
CreativeMotorPeripheralSpeedControllerPeripheralSpeedGaugePeripheralStressGaugePeripheralSequencedGearshiftPeripheralfinalGoing Further
So, these are all the quick fixes, but the real issue is on the de-registering and breaking of existing peripherals, duplicating existing classes, and copying classes that you dont need.
I dont know if an AI told you to do this or something, but you can just
extendorimplementexisting classes and have their methods carry over, you do not need to re-create classes.