Bugs #12
Bugs #12
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
==========================================
+ Coverage 87.14% 87.80% +0.66%
==========================================
Files 25 24 -1
Lines 879 853 -26
==========================================
- Hits 766 749 -17
+ Misses 113 104 -9
Continue to review full report at Codecov.
|
michaelyaakoby
force-pushed
the
bugs
branch
9 times, most recently
from
922d25d to
665cec0
Compare
|
Why did you decide to combile fastapi_http_tracer.py and flask_http_tracer.py into their flask/fast_api_pyctuator.py counterparts? |
michaelyaakoby
force-pushed
the
bugs
branch
2 times, most recently
from
eae3187 to
9b1cfe6
Compare
The splitting to separate classes (they were classes) didn't create better abstractions, on the contrary, it forced us to either register two interceptors, one for recording request/response headers and another for injecting the content-type when needed, or mix the two. |
In order for the "Http Traces" tab to be able to hide requests sent by Spring Boot Admin to the Pyctuator endpoint, `pyctuator_endpoint_url` must be using the same host and port as `app_url`. The examples initially registered the host's IP for `app_url` instead of using the same host as `pyctuator_endpoint_url` - the idea was that the app's URL shown in SBA will be accessible. Also, both FastAPI and Flask examples were logging every request sent from SBA to Pyctuator. This was annoying so the example now are configuring the loggers not to show access-log.
Responses sent by Pyctuator should set content-type to `application/vnd.spring-boot.actuator.v2+json` - the existing mechanism was invoked *after* requests were intercepted so the content-type was missing tom "HTTP Traces" in SBA.
Fixes #11 and more: