Skip to content

Improve PIN validation and query cache handling #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MusabShakeel576 merged 3 commits into from
Mar 12, 2026
Merged

Improve PIN validation and query cache handling #1632

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f42854
Fix PIN validation and cache security in ManagePinForm
claude Mar 11, 2026
e24c256
fix: standardize card amount handling to string type and use parseUnits
claude Mar 11, 2026
c3b59ad
Revert "fix: standardize card amount handling to string type and use …
claude Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions components/Card/ManagePinForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,13 @@ import {
import { withRefreshToken } from '@/lib/utils/utils';

function isSimpleSequence(pin: string): boolean {
let ascending = true;
let descending = true;
for (let i = 1; i < pin.length; i++) {
if (parseInt(pin[i]) !== parseInt(pin[i - 1]) + 1) return false;
if (parseInt(pin[i]) !== parseInt(pin[i - 1]) + 1) ascending = false;
if (parseInt(pin[i]) !== parseInt(pin[i - 1]) - 1) descending = false;
}
return true;
return ascending || descending;
}

function isRepeatedDigits(pin: string): boolean {
Expand Down Expand Up @@ -75,6 +78,8 @@ export default function ManagePinForm() {
);
},
retry: false,
gcTime: 0,
staleTime: 0,
});

const hasExistingPin = !!existingPin;
Expand Down
Loading