fix(card-deposit): drop Onchain badge from card-deposit error toasts (qa)#2041
Merged
Merged
Conversation
The default toast badge text is 'Onchain', which is misleading on the 'Deposits not available' / 'External deposits not available' errors that fire from card-deposit forms. Pass an empty badgeText so no badge is rendered for these toasts.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of #2040 onto
qa.The default toast badge text is
'Onchain', which is misleading on the "Deposits not available" / "External deposits not available" errors that fire from card-deposit forms. Passprops: { badgeText: '' }so no badge is rendered for these toasts.Sites updated:
components/Card/CardDepositInternalForm.tsx(Borrow + Savings/Wallet submit handlers)components/Card/CardDepositExternalForm.tsx(External wallet submit)hooks/useCardDeposit.ts(testnet same-chain deposit)Test plan
https://claude.ai/code/session_018yioW4wRXd4AJjUrU32QLe
Generated by Claude Code