Fix cashback value formatting to preserve decimal precision#2046
Merged
Conversation
The desktop SpendingBalanceCard was rounding totalUsdValue to whole dollars via .toFixed(0), so any cashback under $0.50 rendered as "$0". The mobile CashbackDisplay used .toFixed(2) but then parseFloat-ed it back to a number, dropping trailing zeros (e.g. "$0.30" rendered as "$0.3"). Format both as "$X.XX" strings. https://claude.ai/code/session_01KbGt2z23Ci4FWrvDcC8pEc
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated cashback value formatting in the card details component to maintain two decimal places consistently, improving precision and display accuracy for monetary values.
Key Changes
SpendingBalanceCardcomponent to return cashback total USD value as a string with 2 decimal places (toFixed(2)) instead of parsing to a number with 0 decimal placesCashbackDisplaycomponent with the same formatting fix for consistency0to'0.00'to match the new string format with proper decimal precisionImplementation Details
toFixed(2)), we preserve the decimal precision without floating-point arithmetic issueshttps://claude.ai/code/session_01KbGt2z23Ci4FWrvDcC8pEc