Refactor card waitlist page with new fees modal and card summary#2048
Merged
Conversation
- Update card-onboard page header to "Free Visa Vard" - Replace marketing layout with new "Solid card" summary (free, virtual, 3% cashback, zero top-up fee) - Add "Fees and charges" link that opens a modal with full card details - Extract shared SolidCardSummary component for reuse between the page and modal - Add optional className prop to GetCardButton so it can be full-width inside the modal
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the CardWaitlistPage to extract card feature information into reusable components and added a new modal for displaying fees and charges information.
Key Changes
Extracted SolidCardSummary component: Created a new reusable component that displays the Solid Card title, description, and key features (virtual card, 3% cashback, zero fees). Supports both compact and expanded layouts with customizable labels.
Created CardFeesModal component: New modal that displays detailed fees and charges information, including:
Simplified CardWaitlistPage:
Updated CardWaitlistHeaderTitle: Simplified to display only the title "Free Visa Card" without the descriptive subtitle
Enhanced GetCardButton: Added optional className prop for flexible styling
Implementation Details
https://claude.ai/code/session_01C9cTFFQGryn3WhtPbeLWU5