Skip to content

Refactor card waitlist page with new fees modal and card summary#2048

Merged
MusabShakeel576 merged 1 commit into
qafrom
claude/card-onboard-fees-popup-43f6c
May 6, 2026
Merged

Refactor card waitlist page with new fees modal and card summary#2048
MusabShakeel576 merged 1 commit into
qafrom
claude/card-onboard-fees-popup-43f6c

Conversation

@MusabShakeel576
Copy link
Copy Markdown
Contributor

Summary

Refactored the CardWaitlistPage to extract card feature information into reusable components and added a new modal for displaying fees and charges information.

Key Changes

  • Extracted SolidCardSummary component: Created a new reusable component that displays the Solid Card title, description, and key features (virtual card, 3% cashback, zero fees). Supports both compact and expanded layouts with customizable labels.

  • Created CardFeesModal component: New modal that displays detailed fees and charges information, including:

    • Card summary with gradient background
    • Detailed breakdown of fees (no hidden fees, global acceptance, borrow against savings, security, setup)
    • Call-to-action button to get the card
  • Simplified CardWaitlistPage:

    • Removed loading state and async cashback percentage fetching logic
    • Removed Feature component and getFeatures function
    • Replaced feature list with SolidCardSummary component
    • Added "Fees and charges" button that opens the new modal
    • Cleaned up imports and removed unused hooks (useUser, useEffect)
  • Updated CardWaitlistHeaderTitle: Simplified to display only the title "Free Visa Card" without the descriptive subtitle

  • Enhanced GetCardButton: Added optional className prop for flexible styling

Implementation Details

  • The CardFeesModal uses ResponsiveModal for consistent modal behavior across screen sizes
  • SolidCardSummary supports both compact and expanded layouts for reuse in different contexts
  • Removed hardcoded cashback percentage fetching; now uses a static 3% value
  • Modal state management uses the existing ResponsiveModal pattern with MODAL_STATE and CLOSE_STATE

https://claude.ai/code/session_01C9cTFFQGryn3WhtPbeLWU5

- Update card-onboard page header to "Free Visa Vard"
- Replace marketing layout with new "Solid card" summary (free, virtual, 3% cashback, zero top-up fee)
- Add "Fees and charges" link that opens a modal with full card details
- Extract shared SolidCardSummary component for reuse between the page and modal
- Add optional className prop to GetCardButton so it can be full-width inside the modal
@vercel
Copy link
Copy Markdown

vercel Bot commented May 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
solid-app Ignored Ignored May 6, 2026 9:02am
solid-app-staging Ignored Ignored May 6, 2026 9:02am

Request Review

@MusabShakeel576 MusabShakeel576 merged commit 0cccae6 into qa May 6, 2026
4 of 5 checks passed
@MusabShakeel576 MusabShakeel576 deleted the claude/card-onboard-fees-popup-43f6c branch May 6, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants