Skip to content

custom query editor #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 53 commits into from
Jun 26, 2024
Merged

custom query editor #138

merged 53 commits into from
Jun 26, 2024

Conversation

@EmilioTR
Copy link
Collaborator

@EmilioTR EmilioTR commented Jun 26, 2024

fixes #54

EmilioTR and others added 30 commits May 13, 2024 13:55
@EmilioTR
added custom editor, not fully operational
2f7fe29
@EmilioTR
experimental implememtation, still not good
0bdf196
@EmilioTR
working qury results
655a49a
@EmilioTR
working query prompt and added error handling
0e28667
@EmilioTR
First visual representation, works completely
4f2a5fc
@EmilioTR
temporary attempt to save new queries and show title
1947e11
@EmilioTR
Merge branch 'main' into fix/54-custom-editor
73a8821
@EmilioTR
adding custom query shows it as a loose query in the menu
32c088d
@EmilioTR
Adding custom query now works with a custom group
4dc09ab
@EmilioTR
extracted group adding logic to the manager (more robust for extension)
7818a72
@EmilioTR
added description and multiple source option
9e6671f
@EmilioTR
custom query editor operational
d6cb664
@EmilioTR
Merge branch 'main' into fix/54-CE-bis
4b1eddd
@EmilioTR
update
21e4782
@EmilioTR
formcomponent with searchParams
e4a1a0e
@EmilioTR
Made edit operational and updated structure
d35e197
@EmilioTR
update for a custom query using an index file
f5c5472
@EmilioTR
custom query creation is operational
3cf244e
@EmilioTR
added a little check to prevent a crash when redirecting
45d4f02
@EmilioTR
added a delete function
7d0b292
@EmilioTR
added icons
de22b49
@EmilioTR
UI updates
dbf5029
@EmilioTR
Can now also save queries
6830fa8
@EmilioTR
small UI update
fce29f2
@EmilioTR
small update
b1a4079
@EmilioTR
Added e2e tests for the custom edittor
f088ba2
@mvanbrab
Some text updates
b4a0fdd
@mvanbrab
Another text mod
a5a5e7b
@EmilioTR
extra user experience
9855a4b
@EmilioTR
Merge branch 'fix/54-CE-bis' of https://github.com/SolidLabResearch/g…
7572d1e 
…eneric-data-viewer-react-admin into fix/54-CE-bis
EmilioTR and others added 23 commits June 25, 2024 09:29
@EmilioTR
added a check, to prevent wrong inputs
655c00c
@EmilioTR
updated the buttons UI
f13b9fd
@EmilioTR
added navigate on creation
a86c981
@EmilioTR
meeting feedback added
0a55354
@EmilioTR
finalised custom query tests
19b60e0
@EmilioTR
Merge branch 'main' into fix/54-CE-bis
d8e8834
@mvanbrab
Added custom queries to the README
c633acc
@mvanbrab
CHANGELOG
e9a1703
@mvanbrab
changed placeholders for sources
c872eaf
@mvanbrab
JSON placeholder and initial contents format
54b9f91
@mvanbrab
default SPARQL queries
19719e6
@mvanbrab
custom editor tests work again
c0163f8
@EmilioTR
open query group when a custom query is created/deleted/editted
c4216c7
@mvanbrab
source index query can use any variable name
60059d2
@mvanbrab
doc on source URLs
29e879c
@EmilioTR
changed the scope of templated options to add more features
041421b
@EmilioTR
updated tests
92de0dd
@mvanbrab
Merge branch 'fix/54-CE-bis' into fix/54-CE-bis-martin
46519e2
@mvanbrab
?source in SPARQL query for sources index file
aa7cfe7
@mvanbrab
CHANGELOG
4df496c
@EmilioTR
test fixes
56117ea
@EmilioTR
Merge branch 'fix/54-CE-bis' of https://github.com/SolidLabResearch/g…
6642529 
…eneric-data-viewer-react-admin into fix/54-CE-bis
@EmilioTR
Code clean up
17f52cc
@EmilioTR EmilioTR requested a review from mvanbrab June 26, 2024 12:39
@EmilioTR EmilioTR self-assigned this Jun 26, 2024
mvanbrab
mvanbrab approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@mvanbrab mvanbrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No further remarks.

@EmilioTR EmilioTR merged commit fb444e0 into main Jun 26, 2024
@EmilioTR EmilioTR deleted the fix/54-CE-bis branch June 26, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mvanbrab mvanbrab mvanbrab approved these changes

Assignees

@EmilioTR EmilioTR

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow to add custom query + editor

3 participants

@EmilioTR @mvanbrab